Skip to content

WIP: Update Envoy to 72bf41f (Jun 4th 2021).#690

Closed
mum4k wants to merge 12 commits intoenvoyproxy:mainfrom
mum4k:envoy-update
Closed

WIP: Update Envoy to 72bf41f (Jun 4th 2021).#690
mum4k wants to merge 12 commits intoenvoyproxy:mainfrom
mum4k:envoy-update

Conversation

@mum4k
Copy link
Copy Markdown
Collaborator

@mum4k mum4k commented Jun 5, 2021

Blocked until envoyproxy/envoy#16829 or an alternative gets merged upstream (or an alternative gets implemented here).

  • modified include paths to match recent change done in the envoy repository (envoyproxy/envoy@0fae697), specifically:
    1. Move include/nighthawk up one level by running git mv include/nighthawk nighthawk.
    2. Use full paths on all #include statements referring to packages under the source/ directory.
    3. Fixing incorrect include paths (pre-existing) that were referring to envoy headers without the external/ prefix. This was reported by check_format after the above changes.
  • Changing a bool to envoy::config::core::v3::DnsResolverOptions in a call to Envoy::Event::Dispatcher::createDnsResolver to match a recent Envoy change (envoyproxy/envoy@2c0e1f2).
  • changing how the HTTP connection pool is accessed after it was moved behind a new class HttpPoolData in envoy (envoyproxy/envoy@ff2c0e5).
  • after envoy switched to the true abseil type of string_view (envoyproxy/envoy@72bf41f), we can no longer assign absl::string_view to std::string. Changing Nighthawk code accordingly.

Signed-off-by: Jakub Sobon mumak@google.com

mum4k added 12 commits May 13, 2021 01:27
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
…ark.

Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
As suggested by fix_format.

Signed-off-by: Jakub Sobon <mumak@google.com>
As suggested by fix_format.

Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
…:string.

Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k requested review from dubious90 and oschaaf June 5, 2021 04:53
@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Jun 5, 2021

Going to recreate this without the extra commits that made it into the history here.

@mum4k mum4k closed this Jun 5, 2021
@mum4k mum4k deleted the envoy-update branch June 5, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant